[MPlayer-dev-eng] [PATCH] VF Overlay

[Diego Biurrun]

On Tue, Sep 22, 2009 at 06:54:24PM +0200, Benjamin Zores wrote:
> Jason Tackaberry wrote:
>> On Wed, 2009-08-19 at 02:03 +0200, Benjamin Zores wrote:
>>> Tack, as you wrote the ASM code, can you have a look at this ?
>>> Also, I've noticed you now have a write account so feel free to 
>>> commit this patch whenever you feel it ready as you're the main 
>>> author (I've only performed a few fixes/enhancements on it after 
>>> all).
>>
>> Ok, I'll incorporate Reimar's suggestions hopefully next week and
>> resubmit.
>
> Resurecting an old patch now ...
> Attached is latest version of the patch.
> Tack, have you done any changes or is it OK for everyone to finally get  
> this applied ?

.. ping ..

Tack, will you apply this?

> --- libmpcodecs/vf_overlay.c	(revision 0)
> +++ libmpcodecs/vf_overlay.c	(revision 0)
> @@ -0,0 +1,1214 @@
> +
> +#include "config.h"
> +
> +
> +/// Per-instance private data.
> +struct vf_priv_s {

silly _s suffix

> --- mencoder.c	(revision 29701)
> +++ mencoder.c	(working copy)
> @@ -218,6 +218,11 @@
>  char *current_module;
>  #include "mpcommon.h"
>  
> +// Stubs for filters that might call these functions, to satisfy linker.
> +// These filters are probably only useful for MPlayer.
> +void mp_input_add_cmd_filter(void *func, void* ctx) {}
> +void *mp_input_get_cmd(int time, int paused, int peek_only) { return NULL; }

As I said, a simpler solution might be to just link the objects into
MPlayer.

Diego