[MPlayer-dev-eng] [RFC] include dshow, ddraw, dinput headers

[compn]

On Thu, 21 Jan 2010 11:03:36 +0100, Diego Biurrun wrote:
>On Wed, Jan 20, 2010 at 08:00:54PM +0100, Reimar Döffinger wrote:
>> On Wed, Jan 20, 2010 at 12:06:06PM +0100, Diego Biurrun wrote:
>> > On Tue, Jan 19, 2010 at 09:28:19PM +0100, Reimar Döffinger wrote:
>> > > On Tue, Jan 19, 2010 at 12:11:23PM +0100, Diego Biurrun wrote:
>> > > > On Sun, Jan 17, 2010 at 01:05:49PM +0100, Reimar Döffinger wrote:
>> > > > > http://natsuki.mplayerhq.hu/~reimar/ddraw.h
>> > > > > http://natsuki.mplayerhq.hu/~reimar/dinput.h
>> > > > > http://natsuki.mplayerhq.hu/~reimar/dsound.h
>> > > > > 
>> > > > > ideally I'd like to put them e.g. in osdep and the add -Iosdep to extra_cflags
>> > > > > on win32 so that MPlayer compiles with -vo directx and -ao dsound even on
>> > > > > a fresh, unmodified MinGW installation.
>> > > > > Comments, any variant of this that would be acceptable to everyone?
>> > > > 
>> > > > I'm not terribly fond of this, much of osdep I consider a mistake.
>> > > > 
>> > > > IIRC we already require installing DirectX headers on Windows, so why
>> > > > not require installing a few extra headers?
>> > > 
>> > > We don't require any, MPlayer compiles on a fresh MinGW.
>> > 
>> > Yes, but we require installing some headers for DirectX, right?
>> > 
>> > So why don't we add another package with these headers?
>> 
>> Ah, that's the misunderstanding.
>> We have
>> http://www.mplayerhq.hu/MPlayer/contrib/win32/dx7headers.tgz
>> But the are compressed almost 200 kB, and they include a lot of stuff
>> we don't need and actually conflict with MinGW headers (e.g. d3d.h does).
>> For MPlayer, the above ddraw.h and dsound.h provide exactly the same
>> functionality (dinput.h is only for SDL).
>> Not reading the documentation as usual, I always have a hard time finding
>> that dx7headers file even if I want to use it, so I wanted to have everything
>> in a more convenient place.
>> Is my motivation now a bit clearer?
>
>Yes, your motivation is clear now.
>
>So how about creating a MinGW upgrade package that contains just the
>necessary stuff?

then whats the diff of having users install the 200kb package vs the
20kb package?

the whole point is making things easier. can we include the headers
until they are in mingw?

-compn