[MPlayer-dev-eng] avoid calling SetErrorMode(0x8003) on win32 when --enable-debug is specified

[Gianluigi Tiesi]

On Tue, Jan 26, 2010 at 10:25:49PM +0100, Reimar D?ffinger wrote:
> On Mon, Jan 25, 2010 at 05:04:19AM +0100, Gianluigi Tiesi wrote:
> > it would be fine to ifdef out SetErrorMode(0x8003) call in mplayer
> > if I compile it with enable debug (MP_DEBUG)
> > 
> > it's usefull e.g. when I put a DebugBreak() (int 3)
> > in foreing stuff (at the moment a dll compiled with vc)
> > 
> > seterrmode prevents the debugger popup window
> 
> You could just add a SetErrorMode _and_ a DebugBreak instead of just a
> DebugBreak and then you neither need a special MPlayer build nor
> do we need special #ifdefs.
> However the only one that is non-negotiable of those flags is 0x8000

hmm maybe an idea

> 
> > anyway useful for display uncaugth problems.
> > I think it would also useful not to install exception handlers ("Catch signals" part)
> > at least on win32, since the current code anyway doesn't support calling
> > gdb on crash on win32
> 
> First, they have other purposes like cleaning up the terminal and sending
> ID_SIGNAL to anyone using slave mode.
> Also the gdb stuff should work on Cygwin.

sigtrap is silenty caught, no messages at all, the program just terminates
cygwin does not defines _WIN32

Regards


-- 
Gianluigi Tiesi <sherpya at netfarm.it>
EDP Project Leader
Netfarm S.r.l. - http://www.netfarm.it/
Free Software: http://oss.netfarm.it/