[MPlayer-dev-eng] simple Blu-ray playback [Patch]

[Alexander Roalter]

On 02.07.2010 12:55, Diego Biurrun wrote:
> On Fri, Jul 02, 2010 at 11:09:00AM +0200, Alexander Roalter wrote:
>>
> 
> !file - not that it's particularly important.
done
> 
>> +        mp_msg(MSGT_OPEN, MSGL_ERR, 
>> +            "Cannot open file %s to get UK and DiscID\n", filename);
> 
> Indentation is messed up here, the function arguments should be
> aligned.
Aligned with first parameter. Should in this case all parameters be put
in a separate line? à la
mp_msg(a,
       b,
       c,
       d)

or only do it as long as it fits within the first say 75 characters?
> 
> Please place statements after conditions on the next line.
> 
done
> 
> There should be no such debug printfs in the final version.
removed
> 
> alphabetical order
corrected.
> 

-- 
cheers,
Alex
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bd_stream_7.diff
Type: text/x-patch
Size: 11270 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100702/cc8549c6/attachment.bin>