[MPlayer-dev-eng] [PATCH] vo_tga: fix blue channel on little endian machines

[Reimar Döffinger]

On Sun, Jul 11, 2010 at 10:13:10PM +0200, Marton Balint wrote:
> On Sat, 26 Jun 2010, Marton Balint wrote:
> >On Sat, 26 Jun 2010, Reimar Döffinger wrote:
> >>On Sat, Jun 26, 2010 at 11:08:24AM +0200, Marton Balint wrote:
> >>>@@ -236,7 +196,7 @@
> >>>     switch(format){
> >>>         case IMGFMT_BGR|15:
> >>>         case IMGFMT_BGR|24:
> >>>-        case IMGFMT_BGR|32:
> >>>+        case IMGFMT_BGRA:
> >>
> >>Well, if your previous patch was correct, this is wrong, it should stay
> >>IMGFMT_BGR|32.
> >
> >I think my previous patch was wrong, at the time of writing it I
> >wasn't aware of the fact that IMGFMT_BGRA is endian dependent.
> >Because of so I think using IMGFMT_BGRA is the correct approach.
> >Am I missing something again? :)
> 
> Could someone please review the patch?

Applied, thanks. The 15 bpp case was broken as well, though this
time on big-endian, fixed as well.