[MPlayer-dev-eng] [PATCH] Fix geometry with wid in vo gl2

[Onur Küçük]

On Sun, 18 Jul 2010 20:05:41 +0200
Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:

> On Sun, Jul 18, 2010 at 08:20:34PM +0300, Onur Küçük wrote:
> >  Attached patch fixes the geometry in vo gl2 when used with wid.
> > Without this patch, video is not visible with gl2 with frontends
> > (smplayer, gnome-mplayer etc.). It is kind of a mixture of r31428
> > and r31600 for gl2
> 
> I assume that's what you did as well, but I just copy-and-pasted
> the code from -vo gl.

 Sort of, just the glViewport function name was different
(mpglViewport) :)

 Btw. I experience another problem with gl2 under frontends
(gnome-mplayer) initially the gamma (brightness ?) value is set to
higher than the system, and the whole screen gamma value changes.
Playing with the values through 1,2 etc. keys also changes the values
of the whole screen. Though with gl, the startup is fine, and the keys
only affect the video "in the window".

 I could not find the reason yet. My guess is it is related to WinID as
running mplayer on command line does not do this, but the patch I sent
is the only part in the code using it AFAIS.

 What do you think about this ?

 Maybe related, I get X11 error: BadMatch too

[swscaler @ 0x8a9cf60]using unscaled yuv420p -> rgb24 special converter
VO: [gl2] 720x576 => 720x576 Planar YV12  [zoom]
Resizing to 720 x 576
current size = 720 x 578 
old aspect is 1,245675 new aspect is 1,250000
ERROR: X11 error: BadMatch (invalid parameter attributes)
[gl2] You have OpenGL >= 1.2 capable drivers, GOOD (16bpp and BGR is ok!)
[gl2] antialiasing off
[gl2] bilinear linear 

-- 
 Onur Küçük                                      Knowledge speaks,
 <onur.--.-.delipenguen.net>                     but wisdom listens