[MPlayer-dev-eng] [PATCH] Get Demuxer Time for Proper DVD Time REDUX^2

[Paul Huwe]

Hello,

I submitted the latest version of my patch a week ago, and I haven't heard anything further. I want to make sure it hasn't gotten lost in the shuffle...

Thank you,
Paul


--- On Sun, 7/18/10, Paul Huwe <reicow at yahoo.com> wrote:

> From: Paul Huwe <reicow at yahoo.com>
> Subject: Re: [MPlayer-dev-eng] [PATCH] Get Demuxer Time for Proper DVD Time REDUX^2
> To: mplayer-dev-eng at mplayerhq.hu
> Date: Sunday, July 18, 2010, 5:28 AM
> > > Please let me know if this
> is acceptable. 
> > 
> > Really close :-)
> > 
> > > +    if (!(mpctx->sh_video))
> > > +        return
> > M_PROPERTY_UNAVAILABLE;
> > 
> > Besides the inner () being pointless, this can work
> just
> > fine
> > for e.g. audio-only streams.
> > 
> > > +    switch(action) {
> > > +    case M_PROPERTY_GET:
> > > +       return
> >
> m_property_double_ro(prop,action,arg,mpctx->demuxer->stream_pts);
> > 
> > Whereas it is quite ugly to print it when the value
> is
> > MP_NOPTS_VALUE.
> > I would suggest to change the check to
> > 
> > if (!mpctx->demuxer ||
> mpctx->demuxer->stream_pts
> > == MP_NOPTS_VALUE)
> >     return M_PROPERTY_UNAVAILABLE;
> 
> 
> Here is the patch with your recommended changes. I've
> tested it and it works great.
> 
> 
>       
> -----Inline Attachment Follows-----
> 
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng