[MPlayer-dev-eng] [PATCH] -vf fixpts=use_timer

[Reimar Döffinger]

On Sun, Jul 25, 2010 at 08:29:31AM +0200, Rudolf Polzer wrote:
> On Sat, Jul 24, 2010 at 11:54:56PM +0200, Reimar Döffinger wrote:
> > On Sat, Jul 24, 2010 at 10:59:31PM +0200, Rudolf Polzer wrote:
> > > On Wed, Jul 21, 2010 at 07:55:43PM +0200, Reimar Döffinger wrote:
> > > > On Wed, Jul 21, 2010 at 02:10:24PM +0200, Rudolf Polzer wrote:
> > > > > On Tue, Jul 20, 2010 at 07:28:08PM +0200, Reimar Döffinger wrote:
> > > > > > Oh, and if it's the same code, actually reusing it would be far better
> > > > > > than copying it.
> > > > > 
> > > > > It is not entirely the same, the functions differ because no adjustment to
> > > > > playback speed, or AO buffer size is done. But yes, the common parts (i.e.:
> > > > > what I added to mencoder.c) could be merged into one function. Just no idea
> > > > > where it would belong.
> > > > 
> > > > It's getting a bit messy there, but in lack of a better idea mpcommon.[c|h] should
> > > > do.
> > > 
> > > Attached.
> > 
> > Looks really good to me, though untested.
> > Any objections or testing volunteers?
> 
> I also agree that this needs testing a lot. The mplayer side of it is obviously
> fine, but the mencoder side MAY make things worse in some cases (namely, when
> it causes the "new" audio pts path to be chosen in favor of the old CBR one).
> Who knows if in some files, the "output-based" audio pts part actually does
> worse in mencoder (even though this code is greatly tested in mplayer).

I wouldn't worry too much about that, I only meant to say that I did not even
test compilation and I'd appreciate if some more people find the time to
quickly test it (e.g. if they are going to run an encode anyway).
It always takes me some time to even get a properly working mencoder
command-line since I use it so rarely.