[MPlayer-dev-eng] [PATCH] Fix -geometry option

[Giorgio]

2010/6/1 Reimar Döffinger <Reimar.Doeffinger at gmx.de>:
> On Tue, Jun 01, 2010 at 09:26:54PM +0200, Giorgio wrote:
>> on my system (GNU/Linux) the -geometry option doesn't work as
>> expected. In particular the following commands:
>>
>> 1) mplayer -geometry 50 file.avi
>> 2) mplayer -geometry 50% file.avi
>>
>> do the same thing, placing the window at the center of the screen. If
>> you use the -v option you can see a message like this:
>
> Well, the bug here is not what you think, the first syntax is not supported.
> And personally I think the second one doesn't really make any sense either.

Oh, okay. The man page reads: "-geometry x[%][:y[%]] or [WxH][+-x+-y]"
so I thought you could specify only x if you wanted to.

>> This patch fixes all the cases for me. Although, I'm not sure if there
>> is an easier/cleaner way to fix this issue.
>
> Fixed differently, your patch still would still quitely accept e.g.
> -geometry 50mice

Yes, true! :) I like your solution better. Thanks for fixing it.

Giorgio Vazzana