[MPlayer-dev-eng] [MPlayer-cvslog] r31573 - trunk/configure

[Reinhard Tartler]

On Mon, Jun 28, 2010 at 07:51:54 (CEST), Reimar Döffinger wrote:

> On Sun, Jun 27, 2010 at 09:55:17PM +0200, siretart wrote:
>> Author: siretart
>> Date: Sun Jun 27 21:55:17 2010
>> New Revision: 31573
>> 
>> Log:
>> libvpx does not require static libavcodec
>> 
>> Modified:
>>    trunk/configure
>> 
>> Modified: trunk/configure
>> ==============================================================================
>> --- trunk/configure	Sun Jun 27 21:20:38 2010	(r31572)
>> +++ trunk/configure	Sun Jun 27 21:55:17 2010	(r31573)
>> @@ -7577,9 +7577,6 @@ echores "$_libschroedinger_lavc"
>>  echocheck "libvpx"
>>  if test "$_libvpx_lavc" = auto; then
>>    _libvpx_lavc=no
>> -  if test "$_libavcodec_a" != yes; then
>> -    res_comment="libavcodec (static) is required by libvpx, sorry"
>> -  else
>>      cat > $TMPC << EOF
>>  #include <vpx/vpx_encoder.h>
>>  #include <vpx/vpx_decoder.h>
>> @@ -7593,7 +7590,6 @@ int main(void) {
>>  }
>>  EOF
>>      cc_check -lvpx && _libvpx_lavc=yes && extra_ldflags="$extra_ldflags -lvpx"
>> -  fi
>>  fi
>
> This is _wrong_, we should _not_ link against -lvpx _ever_ if we link against
> dynamic libavcodec, please revert (but feel free to change the comment to e.g.
> "libvpx irrelevant when using dynamic libavcodec").

Okay, I have that revert as prepared in my checkout now. Before
committing it, I'd like to understand one thing:

In the case that the shared libavcodec does not support vp8 (this is for
example the case when using ffmpeg 0.6 and it was not compiled against
libvpx), wouldn't we end up with a copy of mplayer that does not support
vp8 playback at all?

This was the case I had in mind when committing this change.

Oh, now I see it. mplayer is only able to playback vp8 via libavcodec,
so if the shared libavcodec doesn't support vp8, we have lost
anyway. This check only ensures that the mplayer binary gets linked with
-lvpx to satisfy libavcodecs.a's dependencies.

I had the (wrong) understanding that mplayer would interface libvpx
directly. Sorry for the fuzz then, I'll clarify this in a comment.


-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4