[MPlayer-dev-eng] [PATCH] Style tag support for srt and microdvd subtitles

[Uoti Urpala]

On Tue, 2010-05-11 at 19:03 +0000, Kazuo Teramoto wrote:
> Jonatan Nilsson <jh.nilsson <at> gmail.com> writes:
> > This patch adds support for font styles in external srt and microdvd
> > (.sub) subtitles. Srt-subtitles uses html tags to define tags such as

> Any opinion on this patch?
> 
> I'm using it and its works great. I use it with subrip (srt) subtitles that
> mainly use italic and bold.
> 
> I think this is a great addition.

I talked about this patch on irc with ubitux some days ago. My main
issue with it is the amount of complexity and abstraction. Compared to
an alternative much simpler implementation that would just add a
self-contained "convert SRT markup to ASS markup" function and call that
before feeding a line to libass, does the complexity of this patch
really give any significant extra benefit?

I haven't studied this enough to say for sure that that kind of
alternative implementation would be the best choice, but at least I
currently know of no reason why it would be impractical. I'm reluctant
to consider applying the patch unless it's either simplified or there's
an explanation why a simpler version would have significant problems.