[MPlayer-dev-eng] [PATCH] replacement for internal mpg123 fork (mp3lib), Final version?

[Thomas Orgis]

Am Thu, 13 May 2010 19:07:36 +0200
schrieb Thomas Orgis <thomas-forum at orgis.org>: 

> In any case... I think we could transition from the discussion down to
> more actual testing... I would like to read about some experience other
> people have with the current patch;-)

In case it was not clear (as communication on that thread suddenly
ceased), I had an improved version of the patch attached to that post.
I now rebased it on current SVN and am attaching the preliminary final
version of it now.

To summarize: This patch adds a new decoder that uses the external
libmpg123 to replace mp3lib, which is a fork of old mpg123 code.
Improvements that mp3lib made went into libmpg123, among others. The
mpg123 decoder module is written in a way to make it API and binary
compatible to the whole range of official libmpg123 versions out there.
It doesn't enforce any advanced features, but, for example, is ready to
deal with a libmpg123 that defaults to floating point output instead of
16 bit integer, for example.

Audio/video sync should be improved on the old mp3lib behaviour since
pts and pts_bytes is employed, as explained by Uoti. Performance of the
decoder is at least on par with mp3lib, better in configurations that
benefit from improved/rewritten/added optimizations (p.ex.
assembly-optimization on ARM).

Coding style has been iteratively improved (hint: indent is not the
best starting point;-) until no comments were left on that,
functionality is where it should be to replace mp3lib. I would like to
hear from some more people testing it, but apart from that: Is this now
ready to merge?


Alrighty then,

Thomas.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mplayer-libmpg123.diff
Type: text/x-patch
Size: 21970 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100515/09ac7b61/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20100515/09ac7b61/attachment.pgp>