[MPlayer-dev-eng] [PATCH v2] Fix offsetting in Theora video files

[Reimar Döffinger]

On Tue, May 18, 2010 at 12:44:54PM +0200, Giorgio wrote:
> > So either this (or a similar patch) should be applied, or the cropping disabled,
> > imo.
> 
> Here's a patch to disable cropping. In addition, a message like this is printed:
> 
> Opening video decoder: [theora] Theora/VP3
> Frame: 768x784, Picture 512x512, Offset [128,128]
> 
> So, if the user wants to select only the picture region, he can easily
> apply a crop filter (in this case -vf crop=512:512:128:128)

I'd say this is definitely an improvement.
The automated cropping is an interesting idea, but I don't like the proposed
implementations.
The decoders really should not mess with the filter chains, an option there would
be to instead export the offsets via the sh_video_t structure of the stream.
However handling these in MPlayer still will be a bit of a pain I expect.
For example, it should not break with resolution changes and it should adapt when
these values change - and both without adding an ever-growing number of cropping filters.