[MPlayer-dev-eng] [PATCH] Support CineForm HD

Steinar H. Gunderson sgunderson at bigfoot.com
Sun May 23 01:29:09 CEST 2010


On Sun, May 23, 2010 at 01:25:20AM +0200, Reimar Döffinger wrote:
>> +          if (data) {
>> +             *data = 1000;
>> +          }
>> +          if (type) {
>> +             *type = REG_DWORD;
>> +          }
>> +          if (count) {
>> +             *count = sizeof(DWORD);
>> +          }
> Pointless {}

Is this an established MPlayer standard? It's not consistently applied even
within the same file.

>> +          free(c);
>> +          return 0;
> Forgot to change that into a named constant.

Yes, I saw after sending. :-)

I wonder what “return 1” is supposed to be...

/* Steinar */
-- 
Homepage: http://www.sesse.net/



More information about the MPlayer-dev-eng mailing list