[MPlayer-dev-eng] [PATCH] Useless if NULL before free: libmp{codecs, demux}

Clément Bœsch ubitux at gmail.com
Sun Nov 7 21:46:50 CET 2010


On Thu, Nov 04, 2010 at 11:19:50PM +0100, Clément Bœsch wrote:
> Hi again,
> 
> Since the previous patch seems ok, here is the same thing with
> libmpcodecs/libmpdemux.
> 
> I won't send another one anymore since… well you know it's kinda boring.
> But I think most of them are now dropped for good, so it should improve
> very slightly the overall quality and avoid a bunch of trivial commits in
> the future.
> 
> Regards,
> 

OK I lied, here is a patch updated with most of the remaining ones all
over the code. The patch is pretty big and includes other free() functions
just like av_free() or spudec_free() which also include a check.

There are some modules I didn't touch, just like libfaad2; it will be
removed soonish no? Also I may have miss one or two, but I think it's
enough for now…

Since the patch has a 92K size, I gzipped it (DOCS/tech/patches.txt says
it's limited to 80K).

Regards,

-- 
Clément B.
Not sent from a jesusPhone.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-most-of-the-if-p-free-p-all-over-the-code.patch.gz
Type: application/octet-stream
Size: 22923 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101107/3b5e54c3/attachment-0001.obj>


More information about the MPlayer-dev-eng mailing list