[MPlayer-dev-eng] [PATCH] Subtitle display is based on audio - should be video

[gillou.ray at free.fr]

On Sat, 2 Oct 2010 15:50:59 +0200
Nicolas George <nicolas.george at normalesup.org> wrote:

> Le primidi 11 vendémiaire, an CCXIX, gillou.ray at free.fr a écrit :
> > the subtitles demuxing code currently base its timestamps on audio
> > time. That is, when an A/V desync occurs, you see the subtitles of
> > what you are hearing, not what you are seeing. I think this is
> > wrong because subtitles timestamps are based on video, typically
> > synced with scenes changes.
> 
> Some subtitles are here to translate for you something written in a
> foreign language in the video, but most of them are used to help you
> understand what you are hearing. For those, I think that sync with
> audio is more important than sync with video.

In a certain extend, you're right. However, whether the goal is to have
audio or video synced subs, the current audio synchronization seems
more like a bug than a feature, which happens in the situation I
described. When you're not in that situation (e.g. with external text
subs), subtitles are synced with video. Giving the others problems this
patch solves, I think it adds more benefits than drawbacks. A more
consistent subtitle sync code may be a better start to switch to
audio-based sync, if anyone wants to do it :)

		-- gillux
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101002/6a0b3341/attachment.pgp>