[MPlayer-dev-eng] [PATCH] Fix for broken vo_xmga support in GUI mode

[Reimar Döffinger]

On Wed, Oct 06, 2010 at 04:04:25PM -0700, Dirk Porezag wrote:
> OK the reason for all the problems that occur after applying the more aggressive 
> patch is that vo_screenwidth and vo_screenheight are not set up properly and 
> then aspect() breaks. For vo_xmga I was able to fix this by adding this simple 
> extra patch:
> 
> --- mga_template.c.sav  2010-10-06 23:20:19.000000000 +0200
> +++ mga_template.c      2010-10-06 23:23:06.000000000 +0200
> @@ -350,6 +350,7 @@
>         }
>        return VO_TRUE;
>    case VOCTRL_UPDATE_SCREENINFO:
> +      aspect_save_screenres(vo_screenwidth, vo_screenheight);
>  #ifdef VO_XGMA
>        update_xinerama_info();
>  #endif

update_xinerama_info already contains this, the easier fix is to fix the typo
(VO_XGMA vs. VO_XMGA)

> vo_screenheight at all if this VO module is used. In fact, previous versions 
> didn't set up these values either, but the rest of the code was able to handle 
> the situation where vo_screenwidth = vo_screenheight = 0. To be honest, I'm not 
> sure how this should be resolved. Is it an acceptable situation to have 
> vo_screenwidth = vo_screenheight = 0 or should these variables be set up in all 
> cases? If they must be set up, I don't know where to get the screen info from. 

You can only get the from the command-line arguments in such a case.
It is preferable for the code to work without them.
I can have a look now that I know where the issues are.