[MPlayer-dev-eng] [PATCH] Do not escape authentication information

[Clément Bœsch]

On Sat, Oct 16, 2010 at 07:48:13PM +0200, Clément Bœsch wrote:
> Hi,
> 
> URL are url-encoded and so login/password are if specified
> (http_proxy://login:password@...). This causes issues if you try to
> authenticate with special characters. I attached a patch to this mail in
> order to correct this. 'Hope it will be fine.
> 

I may have been too quick once again. In fact, it could be wise to
unescape before sending data, so here is another version of the patch that
should work better than the previous one (for example in case we have:
http_proxy://login:pass@proxy/httP://another_login:another_pass@host)

Also note that the code could need a factorization of the string "Memory
allocation failed\n" that has been used all over the file ; as it belongs
to another patch, i didn't include it and did the same as the rest of the
code.

Regards,

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch-unescape-auth.c
Type: text/x-csrc
Size: 1135 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20101016/bb8eff47/attachment-0001.c>