[MPlayer-dev-eng] [PATCH] fix dvdnav multi-cell menus

[Steaphan Greene]

On 08/16/2011 02:35 PM, Dominik 'Rathann' Mierzejewski wrote:
> On Tuesday, 16 August 2011 at 08:18, Steaphan Greene wrote:
> [...]
>> The attached patch fixes both of these issues, and I have tested it
>> extensively (always with my MPEG2 sync patch, of course) with both
>> normal, and interactive DVDs, and including several examples of actual
>> still frames.  It seems to solve the problem and cause no other new ones
>> that I can find.  Note, it is really only a 2-line change (the rest are
>> all just white-space changes to correct the indenting).
> 
> We prefer dvdnav-discuss mailing list for patches to dvdnav code:
> https://lists.mplayerhq.hu/mailman/listinfo/dvdnav-discuss
> 
> Also, like for MPlayer, please split whitespace changes into a separate
> patch. Note that you can use "final" identation in the lines that
> you change in the functional part of the patch and just bring the rest
> in line with a second, whitespace-only patch.
> 
> Thanks for your contributions.
> 
> Regards,
> Dominik
> 

Ahh, ok.  I didn't see that list on the mplayer mailing lists page
(because, it's not there, actually, now that I look again).

I've signed up for it, and will re-send this patch there.

As for the separation of white-space changes, does that really include
cases like this, where the white-space changes are a direct result of a
functional change (removal the else {} block)?  I leave this question
here on this list, since it seems relevant to mplayer in general.

-- 
Steaphan Greene <sgreene at cs.binghamton.edu>
Lecturer, Computer Science, Binghamton University
GPG public key: http://www.cs.binghamton.edu/~sgreene/gpg.key.txt