[MPlayer-dev-eng] [PATCH] x11_common: XChangeProperty uses long for 32-bits

[Nicolas George]

Le decadi 30 thermidor, an CCXIX, Alexander Strasser a écrit :
>   Would be good if someone could test, and verify if it works
> as intended. I will also try to test it myself, but I can't
> say when I will come to it.

I'll try to ask around if someone has a suitable box to test.

> +    if (prop != pid) { return; }

I don't think it can make any difference, but "(pid_t)prop != pid" may be
more reliable than using the default integer promotions.

>      XChangeProperty(display, window, XA_NET_WM_PID, XA_CARDINAL, 32,
>                      PropModeReplace, (unsigned char *) &pid, 1);

I believe it should be &prop instead of &pid here.

Regards,

-- 
  Nicolas George