[MPlayer-dev-eng] GUI and vo_x11_create_vo_window()

[Reimar Döffinger]

On 19 Aug 2011, at 08:04, Reimar Döffinger <Reimar.Doeffinger at gmx.de> wrote:

> On 19 Aug 2011, at 00:08, Ingo Brückl <ib at wupperonline.de> wrote:
>> Reimar Döffinger wrote on Thu, 18 Aug 2011 23:39:21 +0200:
>> 
>>> I still do not see the difference in behaviour between the global
>>> fullscreen variable and messing with the flags.
>> 
>>> Not really, it goes through the fullscreen global variable first.
>>> And I don't see what you think the advantage of that flag manipulation
>>> is.
>> 
>> This is the flow:
>> 
>> config_video_out(...flags...)   <-flags already according to global fullscreen
>>   -> GUI_SETUP_VIDEO_WINDOW   <-currently no flags
>>   -> vo->config(...flags...)
>>       -> vo_x11_create_vo_window(...flags...)
>> 
>> If the global fullscreen variable is set, flags has VOFLAG_FULLSCREEN. If the
>> GUI decides to have a normal video window, the information is wrong. If flags
>> doesn't have VOFLAG_FULLSCREEN and the GUI has a fullscreen video window, the
>> aspect scaling is wrong. This is the reason why I want to correctly set/unset
>> VOFLAG_FULLSCREEN, because the GUI can't influence with the global fullscreen
>> variable at GUI_SETUP_VIDEO_WINDOW, because it is too late - the flags are
>> already determined.
> 
> I just don't see why you can't set it before or after, both of which should work.
> GUI_SETUP_VIDEO_WINDOW doesn't really seem quite the right place, there has to be additional code anyway e.g. when switching from/to fullscreen.

There is of course also the simplest option of always setting the fullscreen variable and never touch it or vo_fs again.