[MPlayer-dev-eng] [PATCH] Enable gui slave commands

[Reimar Döffinger]

On Sun, Dec 11, 2011 at 12:10:20PM +0100, Ingo Brückl wrote:
> Reimar Döffinger wrote on Sat, 10 Dec 2011 21:49:50 +0100:
> 
> > On Fri, Dec 09, 2011 at 04:42:32PM +0100, Ingo Brückl wrote:
> >> Something like this has been remove in r31378, but in order for slackers to
> >> be able to operate the GUI with a remote control, we need it. I tried to
> >> minimize the impact on non-gui files and think I found a neat solution (first
> >> patch).
> 
> > You shouldn't need the ifdefs in input.
> 
> I assume you mean (only) input.h?

and input.c

> > And obviously you should update the slave.txt documentation.
> 
> Didn't I?

Missed it. Might make sense to say what possible gui messages are
though.

> > I'd also prefer if you'd cast to "const char *" instead of "char *" if
> > possible.
> 
> Sure.
> 
> Would you prefer two separate commits (MPlayer part and GUI part) or one?

I think one is better, one doesn't make sense without the other, or?