[MPlayer-dev-eng] [PATCH] Enhanced Video Renderer (EVR)

[Diego Biurrun]

On Wed, Feb 02, 2011 at 01:03:04PM +0200, Georgi Petrov wrote:
> On Wed, Feb 2, 2011 at 12:39 PM, Diego Biurrun <diego at biurrun.de> wrote:
> > On Wed, Feb 02, 2011 at 08:50:21AM +0200, Georgi Petrov wrote:
> >> On Tue, Feb 1, 2011 at 9:30 PM, Georgi Petrov <gogothebee at gmail.com> wrote:
> >> > On Tue, Feb 1, 2011 at 9:25 PM, Reimar Döffinger
> >> > <Reimar.Doeffinger at gmx.de> wrote:
> >> >> On Tue, Feb 01, 2011 at 08:54:08PM +0200, Georgi Petrov wrote:
> >> >>> /**
> >> >>>  * This file has no copyright assigned and is placed in the Public Domain.
> >> >>>  * This file is part of the w64 mingw-runtime package.
> >> >>>  * No warranty is given; refer to the file DISCLAIMER.PD within this package.
> >> >>>  */
> >> >>
> >> >> Uh, this definitely is not a ZPL license, it says public domain.
> >> >> I can't say I like it because public domain basically only has a legal meaning
> >> >> in the US, but I can't see any reason why this couldn't be included into
> >> >> MinGW (32 bit) if this is correct.
> >> >> And please be careful when say "ZPL", version 1.0 is no GPL-compatible,
> >> >> 2.x are (according to http://www.gnu.org/licenses/license-list.html).
> >> >
> >> > Okay, I see. I will work this out with mingw/mingw-w64 guys and write back.
> >>
> >> Mingw-w64's core is ZPL, but its header files are public domain. This
> >> means that evr.h or any other files I work on will remain public
> >> domain. The core of mingw-w64 (as I understand it) is ZPL exactly
> >> because public domain has no meaning outside US.
> >>
> >> This also means that mingw shouldn't have anything against it, but
> >> they haven't answered yet. Anyway - evr.h and vo_evr.c are going to
> >> change on a daily/weekly basis in the next months, so what do you
> >> suggest? Even if mingw decide to include it (I think they would), are
> >> you against temporary inclusion of evr.h in MPlayer until it get's
> >> better enough? I need to know it order to prepare the first patch.
> >
> > As Reimar said, public domain is not ideal because it is US-specific.
> > What about using the ISC license?
> 
> I think this is getting too complicated for me. One week I'm trying to
> solve stupid license problems I don't even care about. Sorry for this
> bold language, but I just want to write code and get a paid job done,
> especially considering that I'm 2 months behind schedule because of
> such unexpected headers/licenses/Windows filesystem bugs/political
> issues.

Well, if you think this is a burden now, just imagine what it is like
years after the fact.  Unless you fix license issues from the start
they will come back to haunt you forever.

MPlayer is a GPL project.  As such, only GPL-compatible code is allowed
into MPlayer.  We cannot accept code where the license situation is not
clear, since that will render all of MPlayer unusable or unredistributable.

I thought this was documented already, apparently it is not.  I will fix
that shortly.

> What is the most easy way to accomplish this work? It seems that
> nobody except JonY from mingw-w64 wants to help :( Is it so hard to
> write a simple feature for MPlayer?

Is evr.h written by you?  Then stick an ISC license on it.

> Can I submit the patch without evr.h and just require whoever wants to
> build EVR support, to download in from the mingw-w64 project? Once
> DxVA is also implemented, I hope that a critical mass of users will
> arise, who will fight for a more elegant solution. I don't have the
> strength anymore.

In the long term evr.h should be moved out of MPlayer and into the
environment.

Diego