[MPlayer-dev-eng] [PATCH] Enhanced Video Renderer (EVR)

[Diego Biurrun]

On Fri, Jan 28, 2011 at 11:44:09PM +0200, Georgi Petrov wrote:
> 
> I'm trying with the first patch, as simple as possible. Please take a
> look when you have time and point the things that may require changes.
> 
> --- libvo/vo_evr.c	(revision 0)
> +++ libvo/vo_evr.c	(revision 0)
> @@ -0,0 +1,147 @@
> +
> +#include <windows.h>
> +#include <errno.h>
> +#include <stdio.h>
> +#include "config.h"
> +#include "video_out.h"
> +#include "video_out_internal.h"
> +#include "fastmemcpy.h"
> +#include "mp_msg.h"
> +#include "aspect.h"
> +#include "w32_common.h"
> +#include "libavutil/common.h"
> +#include "sub/font_load.h"
> +#include "sub/sub.h"

You are missing stdint.h, most of the other headers are unused and
should be removed.

Extra good karma for leaving an empty line between system and local
headers.

> +static const vo_info_t info =
> +{

static const vo_info_t info = {

> --- configure	(revision 32826)
> +++ configure	(working copy)
> @@ -5202,6 +5206,20 @@
>  
> +echocheck "EVR"
> +if test "$_evr" = auto ; then
> +  _evr=no
> +  header_check evr.h && _evr=yes

What is the situation regarding the evr.h header?  Is it stable or are
you still making changes to it?  If it is stable this check is enough.
If there are incompatible changes you depend on you might wish to make
a more specific check for a required part of the header.

Diego