[MPlayer-dev-eng] [PATCH] Enhanced Video Renderer (EVR)

Diego Biurrun diego at biurrun.de
Wed Feb 2 15:06:35 CET 2011


On Wed, Feb 02, 2011 at 03:29:50PM +0200, Georgi Petrov wrote:
> I've attached an updated patch.

Not much to review so far, so only small nits.

> --- Makefile	(revision 32837)
> +++ Makefile	(working copy)
> @@ -503,6 +503,7 @@
>  SRCS_MPLAYER-$(DIRECT3D)     += libvo/vo_direct3d.c libvo/w32_common.c
>  SRCS_MPLAYER-$(DIRECTFB)     += libvo/vo_directfb2.c libvo/vo_dfbmga.c
>  SRCS_MPLAYER-$(DIRECTX)      += libao2/ao_dsound.c libvo/vo_directx.c
> +SRCS_MPLAYER-$(EVR)          += libvo/vo_evr.c
>  SRCS_MPLAYER-$(DXR2)         += libao2/ao_dxr2.c libvo/vo_dxr2.c
>  SRCS_MPLAYER-$(DXR3)         += libvo/vo_dxr3.c
>  SRCS_MPLAYER-$(ESD)          += libao2/ao_esd.c

alphabetical order

> --- libvo/vo_evr.c	(revision 0)
> +++ libvo/vo_evr.c	(revision 0)
> @@ -0,0 +1,150 @@
> +
> +#include <windows.h>
> +#include <errno.h>
> +#include <stdio.h>
> +#include <stdint.h>
> +#include <evr.h>

At least stdio.h looks unused.

> +static const vo_info_t info =
> +{

static const vo_info_t info = {

Diego


More information about the MPlayer-dev-eng mailing list