[MPlayer-dev-eng] [PATCH] More warnings

[Clément Bœsch]

On Wed, Feb 02, 2011 at 08:53:07PM +0100, Ingo Brückl wrote:
> Clément,
> Diego,
> Reimar,
> 
> I didn't intend to bother anybody.

You're not bothering anyone :)

> As the patch should only affect gui/ I didn't see problems. But ok, I
> can go with the other methods suggested.
> 
> Clément, I agree on fixing existing warnings first. This is what I did in
> gui/. It's free of warnings now, but there are still lines worth clarifying
> where compiler and programmer may not be of one mind.
> 

Good! Too bad I don't use the GUI… :p

> Yes Diego, -Wall is global in CFLAGS, but some of its options are switched
> off there. --enable-extra-warnings is a good idea, but I do not want to start
> a discussion on which warnings are good and which are not.
> 
> If -W{all,extra} doesn't reset warnings, Reimar, I do not lose any defaults,
> only get additional ones. So -Wall doesn't affect warnings that should be
> enabled and already are.
> 
> I regard warnings on "if (a=0)", 

Yes, but imo you should notice there is a problem _very_ quickly :)

> unused parameters,

This is extremely annoying when you have a callback system…

> comparison between signed and unsigned (for example) as quite useful.

This is annoying when doing something like for (int i = 0; i < sizeof(...

Which appears quiet often.

-- 
Clément B.