[MPlayer-dev-eng] [PATCH] More warnings

[Ingo Brückl]

Reimar Döffinger wrote on Sat, 5 Feb 2011 18:51:56 +0100:

> IMO -Wextr mostly enables useless stuff while things that IMO should
> always be on is still missing. I am talking specifically about
> -Wcast-qual -Wwrite-strings -Wundef -Wmissing-prototypes

The extra warnings option doesn't change anything from the existing warnings,
it just *adds*, i.e. in total we'll end up with:

-Wundef -Wall -Wextra -Wcast-align -Wpointer-arith -Wredundant-decls
-Wstrict-prototypes -Wmissing-prototypes -Wdisabled-optimization
-Wno-pointer-sign -Wdeclaration-after-statement

Concerning -Wcast-qual and -Wwrite-strings: When using these you have to very
carefullly distinguish between char * and const char * which could mean a lot
of fixes because this usually isn't done in C programs. Could be a nuisance
when you need to call old char * functions with new const char * variables,
but I'm fine with these, the more warnings the more accurate the programming
the less slips.

Clément Boesch wrote on Sat, 5 Feb 2011 18:38:55 +0100:

> Also, you should wait a bit for Diego's return from fosdem at least :)

Diego Biurrun wrote on Sat, 05 Feb 2011 19:40:49 +0100:

> Hold off from committing until I have had another look into this next week
> after I am back from FOSDEM.

Sure.

Ingo