[MPlayer-dev-eng] [PATCH] vf_delogo: variable rectangle

[Nicolas George]

Le quintidi 15 pluviôse, an CCXIX, Reimar Döffinger a écrit :
> To my knowledge the time stamps used here do reset and wrap-around, and the
> subtitle code does not really work well for that.

I would rather fix this timestamp so that it is reliable. That seems like a
better solution on the long-term. If someone has samples where the global
timestamp is correct but the video filter timestamp is not, please let me
know.

> Which is why I suggested frame numbers, that is easy to make switch
> the location at exactly the desired time, however it does not work
> together with seeking.

Working with seeking is, IMHO, a requisite.

> The reason for the suggestion is that it should be less new code than
> (mis-)using the subreader.

Ok, I did that. I am not very happy with it, it is less robust with more
code, but it is self-contained.

> Though there's even the question if there's a need to use a file or if
> it couldn't just be passed as filter argument.

The situation I wrote it for is to remove badly synced hardcoded subtitles
(this is also the reason for the other patch, the one that dumps the
bounding boxes of the subtitles): that makes about four hundred timestamps
and rectangles. Technically, it is possible to pass them on the command
line on most OS, and I am proficient enough in shell to do it without too
much trouble, but this is not very convenient, and not suitable for a
publicly available option.

> If anything it should be a generic command to change the filter arguments,
> as implement for audio filters.

> It also won't work with mencoder, and I have some doubts about the
> time-based stuff, MPlayer does not have a time-base that will make
> everyone happy.

Indeed, especially with the risk of an A-V desync.

Here is a new version, with a custom format parser.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-vf_delogo-allow-to-change-the-rectangle-based-on-the.patch
Type: text/x-diff
Size: 6904 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110209/355af7cd/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110209/355af7cd/attachment.pgp>