[MPlayer-dev-eng] the great reformatting

Clément Bœsch ubitux at gmail.com
Mon Feb 21 07:51:07 CET 2011


On Mon, Feb 21, 2011 at 01:45:16AM +0100, Ingo Brückl wrote:
> These are four files uncrustified with the latest config file. Is the
> resulting format ok? If yes, I'd commit.
> 
> Ingo

> [...]
> typedef struct {
>     fntChar       Fnt[ASCII_CHRS + EXTRA_CHRS];
>     unsigned char nonASCIIidx[EXTRA_CHRS][UTF8LENGTH];
>     txSample      Bitmap;
>     char          name[MAX_FONT_NAME];
> } bmpFont;
> 

Mmmh I should have checked a bit headers; this alignment doesn't sound
good. Otherwise, what the hell, the code looks good! :)

> [...]
>             if (command[0] & 0x80) {
>                 for (i = 0; i < EXTRA_CHRS; i++) {
>                     if (!Fonts[id]->nonASCIIidx[i][0]) {
>                         strncpy(Fonts[id]->nonASCIIidx[i], command, UTF8LENGTH);
>                         break;
>                     }
>                 }
> 
>                 if (i == EXTRA_CHRS)
>                     continue;
> 
>                 i += ASCII_CHRS;
>             } else
>                 i = command[0];
> 

Are you sure you don't want to try the mod option I mentioned in my last
mail? It would correct this afaik (by adding { } on the else).

-- 
Clément B.


More information about the MPlayer-dev-eng mailing list