[MPlayer-dev-eng] the great reformatting

[Clément Bœsch]

On Mon, Feb 21, 2011 at 11:17:19PM +0100, Ingo Brückl wrote:
> Clément Boesch wrote on Mon, 21 Feb 2011 07:51:07 +0100:
> 
> > Mmmh I should have checked a bit headers; this alignment doesn't sound
> > good.
> 
> Clément changed a parameter in the config (btw, Clément, thank you very
> much for the quick work) and this is the new result. The other three files
> remained as posted before.
> 

Looks good, but it is thanks to you and not uncrustify :)

In fact I realized align_var_struct_span is not enough. This setting won't
_add_ padding, but it won't remove it neither. So there is another setting
to set:

    align_var_def_span = 1

But, this is not enough too. In fact I was afraid uncrustify removed the
variable names from the prototypes here:

> int fntFindID(char *);
> void fntFreeFont(void);
> int fntRead(char *, char *);
> txSample *fntRender(wItem *, int, char *);
> int fntTextWidth(int, char *);

While in fact it was you :)

But it also shows me the indent here is also too much tolerant. In the
real case, this:

    int        fntRead( char * path, char * fname );

Is replaced by:

    int        fntRead(char *path, char *fname);

Which is not fine.

Sorry to delay again. I don't have time to go through the profile tonight
and find the correct setting, but feel free to do it. Also, I'm not
against using uncrustify and manually tweak what is wrong (but fixing the
profile should be the priority).

IMO it's fine, you can go commit that stuff, but you should wait for
Reimar or Diego agreement.

Also, does anyone have something to say about the profile? Any patch to
propose? I personnaly don't like at all playing with tonnes of settings
alone, so please, can we go ahead with this stuff and get it done?

I personally think it would be a good think for instance to have
libmpcodecs re-indented in order to help the situation with ffmpeg, to
have mplayer.c re-indented so new developers don't get afraid too quickly,
to have the GUI re-indented so Ingo can't use his time to his fullest,
etc.

I know it's not fun at all, and it's not for me neither, but it will
improve the situation if anyone can propose better settings.

Regards,

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20110222/f2c46ec9/attachment.pgp>