[MPlayer-dev-eng] [patch 2/5] Dont hardcode filename length

[Tobias Diedrich]

Tobias Diedrich wrote:
> Erik Auerswald wrote:
> > On Wed, Jan 05, 2011 at 01:06:59PM +0100, Diego Biurrun wrote:
> > > So relying on the existence of PATH_MAX is not a problem.
> > > Also, it is being used in other places already.
> > 
> > So nobody is using MPlayer on Debian/GNU Hurd. ;-)
> > 
> > All in all I don't see unconditionally using PATH_MAX as an improvement
> > over 255. For most (relevant) systems both will work fine most of the time.
> 
> Well, we had to change it because we ran into the 255 character
> limit.  Since PATH_MAX is already used in e.g. mplayer.c and other
> places I'm inclined to commit the patch as-is.

Oh, and there is one definitive advantage it brings:
If you want to go and introduce MP_PATH_MAX or something later, it's
easy to grep for PATH_MAX, so you're less likely to miss this one.

-- 
Tobias						PGP: http://8ef7ddba.uguu.de