[MPlayer-dev-eng] [PATCH] Subtitles directories

Reimar Döffinger Reimar.Doeffinger at gmx.de
Wed Jan 5 16:26:55 CET 2011


On Mon, Jan 03, 2011 at 09:02:57PM +0100, Clément Bœsch wrote:
> OK, new try with a better base. I have simplified the patches (especially
> the "Make load of n subtitles directories possible." one) so review is
> easier again.
> 
> So basically, the first patch transforms sub_filenames in a new function
> (append_dir_subtitles) only able to load one directory while the old one
> was doing all the nasty stuff loading subtitles in the video directory and
> in ~/.mplayer/sub. load_subtitles is then updated to load each directory
> one at a time.
> 
> This first patch makes the second one much simpler with just a loop to
> load subtitles in the specified directories.
> 
> 'Hope this will finally be mplayer-compliant to be committed :)

I think it's ok, but I do not feel like reviewing it extensively.
I'll assume you tested it quite well.


More information about the MPlayer-dev-eng mailing list