[MPlayer-dev-eng] [PATCH] Avoid raising error when trying to load a vobsub.

[Reimar Döffinger]

On Sat, Jan 22, 2011 at 11:33:41AM +0100, Clément Bœsch wrote:
> On Sat, Jan 22, 2011 at 11:15:06AM +0100, Reimar Döffinger wrote:
> > On Fri, Jan 21, 2011 at 10:54:27PM +0100, Clément Bœsch wrote:
> > > On Thu, Jan 13, 2011 at 12:38:06AM +0100, Clément Bœsch wrote:
> > > > [...]
> > > > From 3ac94829563a5caba4e14457ea5a95cf03948736 Mon Sep 17 00:00:00 2001
> > > > From: =?UTF-8?q?Cl=C3=A9ment=20B=C5=93sch?= <ubitux at gmail.com>
> > > > Date: Thu, 13 Jan 2011 00:34:38 +0100
> > > > Subject: [PATCH] Avoid raising error when trying to load a vobsub.
> > > > 
> > > 
> > > Ping (j-3)
> > 
> > I haven't checked how vobsubs even appear there, as I understand it normal
> > subs are loaded with -sub and vobsubs with -vobsub so there's no reason
> > for that code to be executed?
> 
> MicroDVD and vobsub share the same extension .sub, so when tracking
> text subtitles, binary .sub also get opened.

Ah, ok. In that case maybe add a comment that it's only to suppress a warning
for the case where we got a vobsub sub into the text-sub autoload list.
What happens though if someone does -sub somevobsub, is it ignored without
warning, too?

> > The detection is also very weak (1 in 256 chance to trigger on random input
> > for example), however I think a incorrect detection can't break anything so it
> > should be ok despite that.
> 
> Another solution would be to check if a .idx with the same name exists in
> the same directory, but this would need a much complex fix, and I'm not
> sure it's that better.

No, I don't think that's better. A vobsub sure has more patterns you could
check for, but I don't think it's worth it.

> 
> -- 
> Clément B.
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/mplayer-dev-eng