[MPlayer-dev-eng] [PATCHES] VOBsub cleanup

[Reimar Döffinger]

On Sat, Jan 22, 2011 at 12:17:21PM +0100, Clément Bœsch wrote:
> diff --git a/mplayer.c b/mplayer.c
> index 67de2b3..70a9725 100644
> --- a/mplayer.c
> +++ b/mplayer.c
> @@ -1079,6 +1079,20 @@ void add_subtitles(char *filename, float fps, int noerr)
>  	    filename_recode(filename));
>  }
>  
> +static int add_vob_subtitle(const char *vobname, const char * const ifo, int force, void *spu)
> +{
> +    if (!vobname)
> +        return 0;
> +
> +    vo_vobsub = vobsub_open(vobname, ifo, force, spu);

I think you should do something about the case where vo_vobsub is already != 0
even if it should not happen yet.
E.g. close the old one and print an error. Or just add an assert.