[MPlayer-dev-eng] [PATCH] Improve the readability of dynamic labels which scroll

Clément Bœsch ubitux at gmail.com
Mon Jan 31 17:04:12 CET 2011


On Mon, Jan 31, 2011 at 01:30:09PM +0100, Ingo Brückl wrote:
> Reimar Döffinger wrote on Sun, 30 Jan 2011 18:41:34 +0100:
> 
> > But with all the reformatting, please also keep in mind that it
> > makes svn log/svn blame etc. harder to use, so always do consider
> > if you can do things in a nicer way that avoids large cosmetic
> > stuff.
> 
> I will, but in that case the only solution would be to forget about the
> "pretty-printed" declarations.
> 
> IMHO there is no need to align the variable names in
> 
> char c;
> unsigned int u;
> 

I don't think we ask for this…

> or the equal signs in
> 
> width = foo(1);
> height = foo(2);
> 
> for example, because there is no significant advantage.
> 

Imo there is in this case. Though, I'm not much interested in flaming
about what style we should follow, but having a consistent one is the most
important thing. Actually, it's not the case, but maybe it will in a near
future.

-- 
Clément B.


More information about the MPlayer-dev-eng mailing list