[MPlayer-dev-eng] [PATCH] Option '-display' for GUI

[Reimar Döffinger]

On Wed, Jun 01, 2011 at 08:55:37PM +0200, Ingo Brückl wrote:
> Remove commented and blocked out code.

Never heard the term "blocked out". Just say only "commented out", that
is clear enough.
Or use the term "disabled".

> Pass argv[0] program name to guiInit() and thus to gtkInit().
> 
> This will allow gtk_init() to pass arguments for initialization.

Doesn't make sense, why would GTK need the program name?
Just hardcoding "gmplayer" should work just fine.
Not that I mind passing the correct value but the commit
message should make sense.

> + if (mDisplayName)
> + {
> +   argc = 3;
> +   arg[1] = "--display";
> +   arg[2] = mDisplayName;
> + }

Maybe add some comments what the purpose is/why it is necessary.