[MPlayer-dev-eng] [PATCH] Option '-display' for GUI

[Reimar Döffinger]

On Thu, Jun 02, 2011 at 02:31:27PM +0200, Ingo Brückl wrote:
> Reimar Döffinger wrote on Wed, 1 Jun 2011 21:40:58 +0200:
> 
> >> Pass argv[0] program name to guiInit() and thus to gtkInit().
> >>
> >> This will allow gtk_init() to pass arguments for initialization.
> 
> > Doesn't make sense, why would GTK need the program name?
> > Just hardcoding "gmplayer" should work just fine.
> 
> Yes, hardcoding works, but normally gtk_init() gets main()'s argc/argv, so I
> felt more comfortable to pass the original value.
> 
> GTK's parsing routine (actually the called GLib parsing routine) uses argv[0]
> to set a program name with g_set_prgname() for GLib. However, it only uses
> the basename of argv[0].

Well, even that is not used for anything useful, is it?

> > Not that I mind passing the correct value but the commit
> > message should make sense.
> 
> I'd prefer to pass the correct value, but in what way does the commit message
> make no sense?

It says "this allows" however as I pointed out it isn't necessary for
that. A commit message that claims something that is just not true is
simply very bad.