[MPlayer-dev-eng] [PATCH] Get rid of warning: "_LIBC" is not defined

[Ivan Kalvachev]

On 6/16/11, Diego Biurrun <diego at biurrun.de> wrote:
> On Thu, Jun 16, 2011 at 02:31:02AM +0200, Ingo Brückl wrote:
>> I can't commit.
>>
>> --- libdvdread4.orig/md5.h	2011-06-16 02:20:03.000000000 +0200
>> +++ libdvdread4/md5.h	2011-06-16 02:13:44.000000000 +0200
>> @@ -23,7 +23,7 @@
>>
>>  #include <stdio.h>
>>
>> -#if defined HAVE_LIMITS_H || _LIBC
>> +#if defined HAVE_LIMITS_H || defined _LIBC
>>  # include <limits.h>
>>  #endif
>
> Are you sure _LIBC is not a 0/1 #define?
>
> In any case this extra condition looks bogus to me.  I'd just drop
> the _LIBC or even both conditions, limits.h is a standard header.

Just a few lines bellow we see.

#ifdef _LIBC
# include <sys/types.h>
typedef u_int32_t md5_uint32;
#else

So (at least) the rest of the code assumes it is ifdef/undef

I'm not commenting on what the header is doing. cleaning it further up
would be rule violation.