[MPlayer-dev-eng] [PATCH] Fix for mpeg2 A/V sync bug.

[Steaphan Greene]

On 06/26/2011 02:49 PM, Reimar Döffinger wrote:
> But this is not code for non-uniform time-stamps really but it is
> reordering.
> And my suspicion is that your change only makes it so that non-B-frames
> which MPlayer can detect break the other correction code you pointed out before.
> If so you could just avoid the obfuscation and put the whole other code
> under "if codec != MPEG-2" for exactly the same effect.

Perhaps.  I don't really have a complete understanding of the MPEG code, 
nor the code that causes this problem in the first place.  For all I 
know, this code was put in place to correct something that may apply to 
other mpeg2 streams, and mpeg1 streams may have this same bug.

I managed to trace this specific bug to just this one mpeg/mpeg2 case, 
which specifically modifies "pts", which triggers this other code and 
throws off the sync.  It seems from my code tracing that any time this 
case is triggered, the correction code will always mess up the sync. 
So, I came up with the simplest change I could find which will only 
correct this one case, and affect nothing else.

Of course, if you have a better, or more complete, solution to this 
problem, that would certainly be preferred.  And, I'd be happy to test 
any potential solutions you may have on the various examples I've found 
which mplayer can no longer play correctly.

Thanks.

-- 
Steaphan Greene <sgreene at cs.binghamton.edu>
Lecturer, Computer Science, Binghamton University
GPG public key: http://www.cs.binghamton.edu/~sgreene/gpg.key.txt