[MPlayer-dev-eng] [PATCH 1/5] Remove some useless static zero initializations.

[Clément Bœsch]

On Sun, May 01, 2011 at 06:25:25PM +0200, Reimar Döffinger wrote:
> On Sun, May 01, 2011 at 02:39:32PM +0200, Clément Bœsch wrote:
> > On Sat, Apr 30, 2011 at 11:58:13PM +0200, Reimar Döffinger wrote:
> > > On Sat, Apr 30, 2011 at 11:35:01PM +0200, Clément Bœsch wrote:
> > > > On Fri, Apr 22, 2011 at 11:47:00AM +0200, Reimar Döffinger wrote:
> > > > > On Sat, Apr 16, 2011 at 12:02:49AM +0200, Clément Bœsch wrote:
> > > > > > @@ -188,16 +188,16 @@ int fixed_vo=0;
> > > > > >  // benchmark:
> > > > > >  double video_time_usage=0;
> > > > > >  double vout_time_usage=0;
> > > > > > -static double audio_time_usage=0;
> > > > > > -static int total_time_usage_start=0;
> > > > > > -static int total_frame_cnt=0;
> > > > > > -static int drop_frame_cnt=0; // total number of dropped frames
> > > > > > +static double audio_time_usage;
> > > > > > +static int total_time_usage_start;
> > > > > > +static int total_frame_cnt;
> > > > > > +static int drop_frame_cnt; // total number of dropped frames
> > > > > >  int benchmark=0;
> > > > > 
> > > > > Outside of functions "static" or not makes no difference
> > > > > concerning this aspect, so you should also remove it
> > > > > from the others.
> > > > 
> > > > Mmmh indeed, that was stupid to ignore globals. I'll update the patch when
> > > > the git mirror will be back (is it already?).
> > > 
> > > Hm, I just enabled it again, but I have no idea if it is up-to-date actually...
> > > 
> > 
> > Thank you, it looks recent enough.
> 
> Tell me if you see issues.
> It is completely the way Michael set it up without any verification
> at least by me.
> 

Sure ok. It's just for RO usage anyway.

> > > > Should I commit it directly
> > > > if the make checkmd5sum is ok?
> > > 
> > > I guess that should be ok.
> > 
> > Patch re-attached since the binary changed (with GCC at least); it looks
> > globals are handled a bit differently. I'll commit this in a few days if
> > no one object.
> 
> Fine, however I'd really prefer if you'd just directly apply changes
> like removing the nonsense
> //"MI2-Trailer.avi";
> comment instead of having it messed in into such changes.
> (I am saying this because I see that sending a separate patch is
> unreasonable effort for it. Same applies to spelling mistakes
> and any simple comment improvements).

Right, ok :)

I'll commit that stuff in the next hour then.

-- 
Clément B.