[MPlayer-dev-eng] [PATCH 3/5] Prettify main MPlayer source file.

[Reimar Döffinger]

On Sun, May 01, 2011 at 06:53:36PM +0200, Clément Bœsch wrote:
> On Sun, Apr 17, 2011 at 07:07:05PM +0200, Reimar Döffinger wrote:
> > On Sun, Apr 17, 2011 at 11:03:45AM +0200, Ingo Brückl wrote:
> > > Reimar Döffinger wrote on Sat, 16 Apr 2011 15:41:33 +0200:
> > > 
> > > > On Sat, Apr 16, 2011 at 12:02:51AM +0200, Clément Boesch wrote:
> > > >> Direct use of uncrustify profile with mplayer.c
> > > 
> > > > I thnk I mentioned it before: I'd really like to have a description
> > > > e.g. in DOCS/tech/svn-howto how to verify that the binary has not
> > > > changed.
> > > > Maybe it can even be done with some helper-stuff in the Makefile.
> > > 
> > > I do (in short):
> > > 
> > >   make file.c
> > >   mv file.o somewhere
> > >   uncrustify file.c
> > >   make file.c
> > >   cmp file.o somewhere/file.o
> > > 
> > > Something like this (with file.c backup) should be easily doable in the
> > > Makefile, but due to my experience in Makefile changes I don't feel like
> > > making a start on it. ;-)
> > 
> > Maybe something like this would do:
> > Index: Makefile
> > ===================================================================
> > --- Makefile	(revision 33269)
> > +++ Makefile	(working copy)
> > @@ -820,6 +820,12 @@
> >  codecs.conf.h: codec-cfg$(EXESUF) etc/codecs.conf
> >  	./$^ > $@
> >  
> > +checksums: $(MPLAYER_DEPS) $(MENCODER_DEPS) mplayer$(EXESUF) mencoder$(EXESUF)
> > +	md5sum $^ > checksums
> > +
> > +check_checksums: $(MPLAYER_DEPS) $(MENCODER_DEPS) mplayer$(EXESUF) mencoder$(EXESUF)
> > +	md5sum -c checksums
> > +
> >  # ./configure must be rerun if it changed
> >  config.mak: configure
> >  	@echo "############################################################"
> > @@ -1112,7 +1118,7 @@
> >  -include $(DEP_FILES) $(DRIVER_DEP_FILES) $(TESTS_DEP_FILES) $(TOOLS_DEP_FILES) $(DHAHELPER_DEPS_FILES)
> >  
> >  .PHONY: all doxygen *install* *tools drivers dhahelper*
> > -.PHONY: checkheaders *clean tests
> > +.PHONY: checkheaders *clean tests check_checksums
> >  
> >  # Disable suffix rules.  Most of the builtin rules are suffix rules,
> >  # so this saves some time on slow systems.
> 
> Do you mind committing this or sth similar? Even if it's not perfect it's
> pretty useful, and i'd like to get done with that bunch of cosmetic
> patches…

Sure, Diego can still flame me on -cvslog if it's bad :-)