[MPlayer-dev-eng] [PATCH] Free GUI config

[Ingo Brückl]

Reimar Döffinger wrote on Mon, 2 May 2011 19:49:59 +0200:

> On Fri, Apr 29, 2011 at 10:45:26AM +0200, Ingo Brückl wrote:
>> It seems that the times when I started programing are far too far away. I'm
>> pretty sure I learned to properly release all memory I'm allocating.

> That is in principle still a good rule, it eases debugging memory
> leaks with valgrind. It also makes it easier to restructure code,
> [...]

Thank you for your detailled answer which I appreciate very much.

My first impression was that the freeing itself is a no-go, but now
I understand that it is rather the chosen place.

> I think it would be reasonable to put it in guiDone with a comment
> that it won't be quite correct in some corner-cases.

I'll do something similar, but will stay in gui/ for that.

> and not cluttering the core code with Gui-code which has its issues
> (including making both Gui and core code harder to understand).

Well, in this particular case I think that there would be less clutter with
a core code change, but I got your point.

Ingo