[MPlayer-dev-eng] [PATCH] Windows GUI with mingw64 and cygwin revised part 2
Diego Biurrun
diego at biurrun.de
Fri May 6 11:28:39 CEST 2011
On Thu, May 05, 2011 at 06:00:42PM +0000, Stephen Sheldon wrote:
> This patch contains the fixes for gfree and free in gui/win32. Ingo
> has already fixed gui/interface.h. I also included the change
> to use CreateThread, which allows the Windows gui to work when
> compiled with Cygwin.
"I also included the change X" is not a good way to start a patch
submission. Please split this change into a separate patch.
> --- gui/win32/dialogs.h (revision 33379)
> +++ gui/win32/dialogs.h (working copy)
> @@ -34,7 +34,6 @@
> #define SOLID_GREY (HBRUSH) CreateSolidBrush(RGB(232, 232, 232))
> #define SOLID_GREY2 (HBRUSH) CreateSolidBrush(RGB(175, 175, 175))
>
> -#define gfree free
>
> #define MAXFILE 1024
Nit: Please remove one of the empty lines.
Diego
More information about the MPlayer-dev-eng
mailing list