[MPlayer-dev-eng] [PATCH] Gui: remove unused variables
Martin Simmons
martin at dyxyl.com
Sun May 8 03:27:15 CEST 2011
>>>>> On Sat, 7 May 2011 20:52:06 +0200, Reimar Döffinger said:
>
> Hello,
> seems quite obvious to me, but in case someone has comments...
> - if (guiIntfStruct.mpcontext) {
> - audio_out = mpctx_get_audio_out(guiIntfStruct.mpcontext);
> - video_out = mpctx_get_video_out(guiIntfStruct.mpcontext);
> - mixer = mpctx_get_mixer(guiIntfStruct.mpcontext);
> - }
> + if (guiIntfStruct.mpcontext)
> + mixer = mpctx_get_mixer(guiIntfStruct.mpcontext);
>
> switch (type) {
> case guiXEvent:
> @@ -707,7 +700,7 @@
> break;
>
> case guiSetVolume:
> - if (audio_out) {
> + if (mixer) {
It's not quite the same: mpctx_get_audio_out can return NULL (e.g. -ao none)
but mpctx_get_mixer can never return NULL.
More information about the MPlayer-dev-eng
mailing list