[MPlayer-dev-eng] compiling mplayer with gcc 4.6, broken audio decoding

[Ivan Kalvachev]

On 5/8/11, Ivan Kalvachev <ikalvachev at gmail.com> wrote:
> On 4/30/11, Jindrich Makovicka <makovick at gmail.com> wrote:
>> On Thu, 31 Mar 2011 07:12:34 -0300
>> Kazuo Teramoto <kaz.rag at gmail.com> wrote:
>>
>>> On Thu, Mar 31, 2011 at 6:25 AM, Kazuo Teramoto <kaz.rag at gmail.com>
>>> wrote:
>>> > But if I change the -O2 to -O0, I don't get the warning AND I don't
>>> > get the very high pitch sound with mp3lib.
>>> >
>>> > So, in summary compiling the mp3lib/dct64_sse.c with gcc 4.6 and
>>> > -O0, I don't get the high pitch sound with mp3lib.
>>> >
>>>
>>> I learned about the --save-temps! (sorry about my lack of gcc
>>> expertise =])
>>>
>>> So I'm attaching the .s of -O1 and -O0 of the dct64_sse.c file compile
>>> with the gcc 4.6 on my machine.
>>>
>>> PS. Any more flag I'm missing?
>>>
>>> Regards,
>>> Kazuo.
>>>
>>
>> Can you try this change? It's not a proper fix, but it makes
>> gcc 4.6 emit complete nnnn table in the output.
>>
>> Index: dct64_sse.c
>> ===================================================================
>> --- dct64_sse.c	(revision 33341)
>> +++ dct64_sse.c	(working copy)
>> @@ -112,7 +112,6 @@
>>      }
>>
>>      {
>> -        real *costab = costab_mmx + 24;
>>          int i;
>>
>>          __asm__(
>> @@ -121,7 +120,7 @@
>>              "movaps    %1, %%xmm5\n\t"
>>              "movaps    %%xmm5, %%xmm6\n\t"
>>              :
>> -            :"m"(*costab), "m"(*nnnn)
>> +            :"m"(costab_mmx[24]), "m"(*nnnn)
>>             );
>>
>>          for (i = 0; i < 0x20; i += 8)
>>
>>
>> Regards,
>> --
>> Jindrich Makovicka
>
> If I remember correctly you are developer.
> Would you commit the workaround on your own?
>
> I do not want to delay this fix any longer so I intend to commit it soon.

Committed.
Sorry it took so long.