[MPlayer-dev-eng] [PATCH] vf_delogo: variable rectangle

[Reimar Döffinger]

On Sun, May 22, 2011 at 10:10:37AM +0200, Nicolas George wrote:
> Le decadi 30 floréal, an CCXIX, Reimar Döffinger a écrit :
> > I considered exit_mplayer a "hard abort".
> > And I can't quite decide whether it is better or worse: If someone ever
> > used the function in code that somehow might be called by exit_mplayer you
> > can now get an endless recursion.
> 
> This is a valid concern, indeed.
> 
> > Some arbitrary value like INT_MAX (or rather some fixed constant that will
> > always fit in an int) also has the advantage that behaviour will be the
> > same on all systems.
> > But either way I think there has been enough pointless discussion. I sure
> > think that reusing the existing function is better (since it is tested and
> > has several users), and that exiting on failure has no real advantages but
> > has several issues including discouraging really good code but if I can't
> > convince you just go ahead.
> 
> I rewrote the delogo patch without relying on new utility functions. Do you
> like it better that way?

Yes, I'd say go ahead.
But I'd like to say that despite the criticism I do appreciate your
efforts to improve things.
For example I also do agree that the struct_realloc function is useful
and the current name and location is really crappy.
Though I also think the most straight-forward way to get things moving
(and in the process fully understand the requirements and issues) is
to just extract common code with as little changes as possible as a
first step.