[MPlayer-dev-eng] [PATCH] fix direct3d crash on window minimization
Roger Pack
rogerdpack2 at gmail.com
Sat Nov 12 16:12:49 CET 2011
> I am not familiar enough with vo direct3d to tell you if the patch
> is a correct solution. The whole OSD rendering mechanism in vo direct3d
> was a bit to complex for me to grasp immediately.
>
> But at the very least the comments are inaccurate after your patch is
> applied. This in itself is a rather bad sign. Therefore the patch should
> not be committed as is.
>
> How would you modify the comments after your change? No need to change
> the patches yet! Just write us how you would extend the comments.
Hmm.
After looking a bit more closely, I think maybe only the last "3rd" of
the commit is probably needed.
So...I would modify that and I guess leave the comments the same [?]
@@ -1029,7 +1029,7 @@
static void draw_osd(void)
{
// we can not render OSD if we lost the device e.g. because it
was uncooperative
- if (!priv->d3d_device)
+ if (!priv->d3d_device || !priv->d3d_texture_osd)
return;
if (vo_osd_changed(0)) {
More information about the MPlayer-dev-eng
mailing list