[MPlayer-dev-eng] [PATCH]: vo_caca.c: improve mouse/keyboard handling

[Paul B. Mahol]

On 11/18/11, Reimar Doeffinger <Reimar.Doeffinger at gmx.de> wrote:
> On Thu, Nov 10, 2011 at 02:19:41AM +0000, Paul B. Mahol wrote:
>> +        case CACA_KEY_F1:
>> +        case CACA_KEY_F2:
>> +        case CACA_KEY_F3:
>> +        case CACA_KEY_F4:
>> +        case CACA_KEY_F5:
>> +        case CACA_KEY_F6:
>> +        case CACA_KEY_F7:
>> +        case CACA_KEY_F8:
>> +        case CACA_KEY_F9:
>> +        case CACA_KEY_F10:
>> +        case CACA_KEY_F11:
>> +        case CACA_KEY_F12:
>> +        case CACA_KEY_F13:
>> +        case CACA_KEY_F14:
>> +        case CACA_KEY_F15:
>> +            mplayer_put_key(KEY_F + key - 0x119);
>
> Did you mean - CACA_KEY_F1? That hard-coded 0x119
> seems like a really bad idea.
> Looks good to me otherwise, except that the issue that
> at most one even is processed per check_events call still
> remains.

Fixed both issues.

Additionaly caca1x.diff stop pointless dither recreation calls on resize.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: caca1.diff
Type: text/x-diff
Size: 7609 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20111118/bae4a695/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: caca1x.diff
Type: text/x-diff
Size: 8750 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20111118/bae4a695/attachment-0001.bin>