[MPlayer-dev-eng] demux_pva fixes

Matteo Giani matteo.giani at gmail.com
Mon Oct 10 18:21:32 CEST 2011


All,

I noticed current svn was not working correctly on quite a few of the PVA format samples, in particular it would not decode audio correctly.

After looking into it, I realised the demuxer did not set the "needs_parsing" flags inside the audio and video sh structures, which in particular for audio caused the mentioned breakage.
I guess this flag was a later addition to the rest of the demux code, which demux_pva was not adapted to comply with.

Patch attached does 3 things:

* adds setting of needs_parsing flags
* fixes behaviour in case a PES audio header in the source file did not contain PTS field
* some cleanup / simplification (e.g. removing unused / useless #ifdef blocks which were originally there for testing back in the day, etc)

n.b. I am the original author of the demuxer, just recently found a couple of hours to look at what had become of it.

Furthermore, it was suggested by Carl Eugen hat the way to go would be to make the ffmpeg PVA demuxer the default for these files. To this extent, I can confirm the ffmpeg libavformat PVA demuxer works for all the samples I have access to.

Best regards,

Matteo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: demux_pva_20111010.diff
Type: application/octet-stream
Size: 9791 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20111010/078097ba/attachment.obj>


More information about the MPlayer-dev-eng mailing list