[MPlayer-dev-eng] Compiling MPlayer under Wine

[Reimar Döffinger]

On 12 Oct 2011, at 23:55, Ingo Brückl <ib at wupperonline.de> wrote:

> I wrote on Mon, 10 Oct 2011 21:19:10 +0200:
> 
>> Reimar Döffinger wrote on Mon, 10 Oct 2011 17:29:57 +0200:
> 
>>> On Mon, Oct 10, 2011 at 03:48:22PM +0200, Ingo Brückl wrote:
> 
>>>> +#define IID_IUnknown MP_IID_IUnknown
>>>> +#define IID_IClassFactory MP_IID_IClassFactory
> 
>>> Those belong to where the they are declared, and I don't see a reason to
>>> make them WINE-only.
> 
>> My idea was to avoid their (unneeded) declarations by the Wine header files
>> here which could leave the loader sources untouched. But if I get you
>> right, you mean something like (new) patch #6? (I'm not too familiar with
>> Windows programming and these GUIDs and though IID_IUnknown and
>> IID_IClassFactory must be defined.)
> 
> Was I off base with my idea? Does the patch correspond with your
> expectations? If so, may I commit?

Yes, I was just busy travelling.
Though for the second patch I'd place the define immediately next to the corresponding declaration.
>